Github user osma commented on the pull request:
https://github.com/apache/jena/pull/51#issuecomment-92086474
Hi Alexis!
> For the moment, it's the responsability of the client code to commit or
rollback the index (finishIndexing() or abortIndexing() methods) in phase with
the associated dataset transaction.
I think that synchro should be manage directly from jena (jena-arq?)
Yes, that sounds sensible. For example I use jena-text mainly via Fuseki,
so there is no opportunity for me to tell Fuseki to call any jena-text methods.
> However, I realize that we have here two distinct issues, the
multilingual-index and the dataset/index transactions synchronization.
> Do you think it should be a better way to close this issue and re post 2
distinct pull requests from 2 related branches ?
Indeed it seems that this pull request addresses two separate issues. If
you can easily split that into two separate pull requests, it would help
merging them. It's easier to address new features one at a time.
Also rebasing your code on the current upstream jena-text would of course
help. A pull request that doesn't apply to the current code is not very easy to
merge...
-Osma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
