[
https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539591#comment-14539591
]
ASF GitHub Bot commented on JENA-938:
-------------------------------------
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/58#issuecomment-101213856
JENA-938
(using this PR to cover #60, #61, #62, #63)
Some of these are style points:
Unthrown checked exceptions: many (not all but most in my sampling) of
these are where the interface declaration has an exception but the code
implementation does not throw it currently.
Autogenerated code from an interface will include the exception declaration
and it is a right to have a later change and then throw the exception. This
will have an effect if the app code is using the implementing class, so when an
interface is part, not all, of a classes contract.
Unnecessary superinterface declarations: this is style - if inheriting from
a base class. it can be clearer to keep the "implement interface".
Needless typecasts: probably a left-over from converting to generics and
should be cleared. Or int/long conversion which also can be cleared up.
In all cases, a principle of "keep even if redundant to be clear" needs to
apply. (For me, the int/long cast conversion can fall into that category -
can't remember the rules at the time and probably won't next time I see the
code and certainly do not want accidiently truncation!)
Unused imports: my personal preference is no unused imports.
#58 also mentions unused variables (almost always should go IMO), unused
fields (almost always should go, occasional they are internal trackers like
stats.
> Clean up dead code
> ------------------
>
> Key: JENA-938
> URL: https://issues.apache.org/jira/browse/JENA-938
> Project: Apache Jena
> Issue Type: Task
> Components: Jena
> Affects Versions: Jena 3.0.0
> Reporter: A. Soroka
> Priority: Minor
> Labels: cleanup, jena
>
> This is an umbrella task to which several PRs will be attached, each
> containing "clean up" for some modules in Jena. Each PR will contain only
> non-controversial emendations, such as the removal of unused imports or
> unthrown exceptions. Specifically disallowed are the removal of actual logic
> or methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
