[ 
https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554157#comment-14554157
 ] 

ASF GitHub Bot commented on JENA-938:
-------------------------------------

Github user afs commented on the pull request:

    https://github.com/apache/jena/pull/62#issuecomment-104236721
  
    Re: private methods
    
    I turned on Eclipse's "warn on unused private member" which includes 
private methods, (it does not seem to separate the two).
    
    A quick scan of code I recognized suggests they represent functionally 
there for completeness, maybe also used at one time, just not currently active. 
 That represents useful code IMO.  
    
    I didn't find much that seemed removable so, from my limited experiment, it 
does not look like it would be so useful / much return-on-investment.
    
    "Mostly harmless"


> Clean up dead code
> ------------------
>
>                 Key: JENA-938
>                 URL: https://issues.apache.org/jira/browse/JENA-938
>             Project: Apache Jena
>          Issue Type: Task
>          Components: Jena
>    Affects Versions: Jena 3.0.0
>            Reporter: A. Soroka
>            Priority: Minor
>              Labels: cleanup, jena
>
> This is an umbrella task to which several PRs will be attached, each 
> containing "clean up" for some modules in Jena. Each PR will contain only 
> non-controversial emendations, such as the removal of unused imports or 
> unthrown exceptions. Specifically disallowed are the removal of actual logic 
> or methods. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to