Claude, Rob,

I took a look at our outstanding pull requests on github.

I was wondering if you have a moment to assess them. It's clearing up suggestions from ajs6f, not bug fixes nor new features. They were part of large sets of changes over several modules but ajs6f very kindly broken them up in units that reflect the module structure of Jena.

Claude:

"Nonfunctional cleanup in jena-querybuilder"
https://github.com/apache/jena/pull/68

the bulk of this is subQuery is known to be instanceof the various cases do the if/instanceof isn't necessary. Your choice on style.


Rob:

"Nonfunctional cleanup in jena-jdbc"
https://github.com/apache/jena/pull/62

Much of this is adjusting the throws clauses on @Override methods.
I personally prefer normally to keep the throws even if not actually thrown because they are in the contract of the interface. I didn't apply similar changes elsewhere.

        Andy

Reply via email to