Andy, I did a review and the changes make sense (the structure is a holdover from a very early incarnation). I would do the merge but I don't know.
a) what id to use on github to do the merge? or do I do the merge elsewhere? b) I am not certain what actions I would take to do the merge. Claude On Fri, May 29, 2015 at 5:27 PM, Andy Seaborne <[email protected]> wrote: > Claude, Rob, > > I took a look at our outstanding pull requests on github. > > I was wondering if you have a moment to assess them. It's clearing up > suggestions from ajs6f, not bug fixes nor new features. They were part of > large sets of changes over several modules but ajs6f very kindly broken > them up in units that reflect the module structure of Jena. > > Claude: > > "Nonfunctional cleanup in jena-querybuilder" > https://github.com/apache/jena/pull/68 > > the bulk of this is subQuery is known to be instanceof the various cases > do the if/instanceof isn't necessary. Your choice on style. > > > Rob: > > "Nonfunctional cleanup in jena-jdbc" > https://github.com/apache/jena/pull/62 > > Much of this is adjusting the throws clauses on @Override methods. > I personally prefer normally to keep the throws even if not actually > thrown because they are in the contract of the interface. I didn't apply > similar changes elsewhere. > > Andy > -- I like: Like Like - The likeliest place on the web <http://like-like.xenei.com> LinkedIn: http://www.linkedin.com/in/claudewarren
