[
https://issues.apache.org/jira/browse/JENA-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265677#comment-16265677
]
ASF GitHub Bot commented on JENA-1434:
--------------------------------------
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/315#discussion_r153043716
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/system/ErrorHandlerFactory.java ---
@@ -221,6 +224,64 @@ public void fatal(String message, long line, long col)
{
}
}
+ /** An error handler that logs message for errors and warnings and
throw exceptions on either */
+ public static class ErrorHandlerTracking extends ErrorLogger
implements ErrorHandler {
+ private final boolean failOnError, failOnWarning;
+ private long errorCount, warningCount;
+
+ public ErrorHandlerTracking(Logger log, boolean failOnError,
boolean failOnWarning) {
--- End diff --
Suggestion: `ErrorHandlerTracking` wraps another `ErrorHandler` as argument
and forwards all warning/error/fatal calls to that error handler after
incrementing its counters. This makes the choice of how to respond to warning
or error dependent on the argument `ErrorHandler`.
> Allow warnings to be treated as errors by RIOT
> ----------------------------------------------
>
> Key: JENA-1434
> URL: https://issues.apache.org/jira/browse/JENA-1434
> Project: Apache Jena
> Issue Type: Improvement
> Components: RIOT
> Affects Versions: Jena 3.5.0
> Reporter: Ian Dickinson
> Assignee: Rob Vesse
>
> I would like to use `riot --validate` as part of an integration test for a
> system that generates Turtle. Ideally, the exit status for the riot command
> would be non-zero, indicating a problem, if the input was not valid. However,
> I see an exit status of zero always:
> {noformat}
> $ riot --validate alert.ttl && echo 'exit status is: ' $?
> 13:50:37 WARN riot :: [line: 39, col: 25] Lexical form
> '2017-03-19T00:00:00+00:00' not valid for datatype XSD date
> 13:50:37 WARN riot :: [line: 42, col: 20] Lexical form ''
> not valid for datatype XSD date
> 13:50:37 WARN riot :: [line: 58, col: 20] Lexical form ''
> not valid for datatype XSD date
> exit status is: 0
> {noformat}
> Version info:
> {noformat}
> $ riot --version
> Jena: VERSION: 3.5.0
> Jena: BUILD_DATE: 2017-10-30T09:20:28+0000
> RIOT: VERSION: 3.5.0
> RIOT: BUILD_DATE: 2017-10-30T09:20:28+0000
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
