[
https://issues.apache.org/jira/browse/JENA-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333649#comment-16333649
]
ASF GitHub Bot commented on JENA-1457:
--------------------------------------
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/343#discussion_r162823649
--- Diff:
jena-core/src/test/java/org/apache/jena/graph/GraphWithPerformContractTest.java
---
@@ -68,7 +68,13 @@ public void testPerformAdd_Triple() {
g.performAdd(triple("S3 P3 O3"));
txnCommit(g);
GL.assertEmpty();
+ txnRun( g, new Runnable() {
--- End diff --
There is no need to explicitly have a `Runnable` here or in the other uses:
```
txnRun( g, ()->assertTrue(g.contains(triple("S3 P3 O3"))) );
```
makes the tests shorter and clearer.
> Graph contract tests do not properly support transactions
> ---------------------------------------------------------
>
> Key: JENA-1457
> URL: https://issues.apache.org/jira/browse/JENA-1457
> Project: Apache Jena
> Issue Type: Bug
> Components: Core
> Reporter: Claude Warren
> Assignee: Claude Warren
> Priority: Minor
>
> The Contract test for Graphs do not properly support transactions.
> Specifically, if the graph supports transactions all actions should be
> enclosed within a transaction.
> The easiest test for this is to test the GraphTxnTDB implementation as it
> will fail if transactions are not properly used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
