[ 
https://issues.apache.org/jira/browse/JENA-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351747#comment-16351747
 ] 

ASF GitHub Bot commented on JENA-1457:
--------------------------------------

GitHub user Claudenw opened a pull request:

    https://github.com/apache/jena/pull/352

    Fixes for JENA-1457 - Fix graph contract test transaction usage

    Fixed removed unnecessary "new Runnable()" constructs and reverted 
JSONInput.java to master branch version. 
    
    As part of addition ot JENA-1457 this updates junit-contracts to version 
0.2.0
    
    Also added .recommenders directory to RAT exclude. (it was already in 
.gitignore)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Claudenw/jena 
FixGraphContractTestTransactionUsage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #352
    
----
commit 50703b41060227741304d5e6e236ef57c10b6df8
Author: Claude Warren <claude@...>
Date:   2017-12-29T20:45:33Z

    fixed Graph tests

commit 20b78ae0ddc7a2102602a28f9ed3f48a40c99a1b
Author: Andy Seaborne <andy@...>
Date:   2017-12-18T14:49:40Z

    Blank node labels for JSON Result Set reading

commit 30989a54b4aec3453152ce970832eea8e8acc0d3
Author: Claude Warren <claude@...>
Date:   2018-01-20T10:10:53Z

    Merge remote-tracking branch 'apache/master' into 
FixGraphContractTestTransactionUsage

commit fa23c25835247e2586ed37ad491c45322dca45b6
Author: Claude Warren <claude@...>
Date:   2018-01-20T10:40:33Z

    Added .recommenders to RAT exclusion.

commit 185badb543a6290ae533a0142f416ab4f466043b
Author: Claude Warren <claude@...>
Date:   2018-01-20T21:29:36Z

    Updated version number for junit-contracts to 0.2.0

commit 363e95818710ec45352bf8e1330dcf3bf1f59686
Author: Claude Warren <claude@...>
Date:   2018-01-21T12:13:23Z

    Merge branch 'master' into FixGraphContractTestTransactionUsage

commit 02ae2697dbc265c98c21885d284a7c0210125a5c
Author: Claude Warren <claude@...>
Date:   2018-02-04T10:56:18Z

    Removed unnecsssary "new Runnable()" constructs

commit 567f40531b02ea4808a51837ae8005b98da76886
Author: Claude Warren <claude@...>
Date:   2018-02-04T11:05:28Z

    Merge branch 'master' into FixGraphContractTestTransactionUsage

commit 0d0beae44bf92ddb7b4b755d58819621d7163d75
Author: Claude Warren <claude@...>
Date:   2018-02-04T11:11:46Z

    reverted to master version

----


> Graph contract tests do not properly support transactions
> ---------------------------------------------------------
>
>                 Key: JENA-1457
>                 URL: https://issues.apache.org/jira/browse/JENA-1457
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: Core
>            Reporter: Claude Warren
>            Assignee: Claude Warren
>            Priority: Minor
>
> The Contract test for Graphs do not properly support transactions.  
> Specifically, if the graph supports transactions all actions should be 
> enclosed within a transaction.
> The easiest test for this is to test the GraphTxnTDB implementation as it 
> will fail if transactions are not properly used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to