[ 
https://issues.apache.org/jira/browse/JENA-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488746#comment-16488746
 ] 

ASF GitHub Bot commented on JENA-1542:
--------------------------------------

Github user rvesse commented on a diff in the pull request:

    https://github.com/apache/jena/pull/414#discussion_r190533210
  
    --- Diff: 
jena-text/src/test/java/org/apache/jena/query/text/TestTextTxn.java ---
    @@ -0,0 +1,341 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.jena.query.text;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assume.assumeTrue;
    +
    +import java.io.Reader;
    +import java.io.StringReader;
    +import java.util.Arrays;
    +import java.util.Collection;
    +import java.util.List ;
    +
    +import org.apache.jena.atlas.iterator.Iter ;
    +import org.apache.jena.atlas.lib.Creator;
    +import org.apache.jena.atlas.lib.StrUtils ;
    +import org.apache.jena.query.* ;
    +import org.apache.jena.rdf.model.Model ;
    +import org.apache.jena.sparql.core.Quad ;
    +import org.apache.jena.sparql.sse.SSE ;
    +import org.apache.jena.system.Txn;
    +import org.apache.jena.tdb.TDBFactory ;
    +import org.apache.jena.tdb2.TDB2Factory;
    +import org.apache.jena.vocabulary.RDFS ;
    +import org.apache.lucene.index.DirectoryReader;
    +import org.apache.lucene.index.IndexReader;
    +import org.apache.lucene.index.IndexWriter;
    +import org.apache.lucene.store.Directory ;
    +import org.apache.lucene.store.RAMDirectory ;
    +import org.junit.Test ;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
    +import org.junit.runners.Parameterized.Parameters;
    +
    +/** Text dataset tests using datasets transactionally, named 
unionDefaultGraph.
    + * <p>
    + * Note that in Lucene, writes are not visible to a reader of the {@code 
Directory}
    + * until committed. A special {@link IndexReader} is needed. See
    + * {@link DirectoryReader#open(IndexWriter)}. jena-text does not currentyl 
do this.
    --- End diff --
    
    Typo - `currentyl`


> Allow addition of transaction components after initial setup.
> -------------------------------------------------------------
>
>                 Key: JENA-1542
>                 URL: https://issues.apache.org/jira/browse/JENA-1542
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: TDB, TDB2
>    Affects Versions: Jena 3.7.0
>            Reporter: Andy Seaborne
>            Assignee: Andy Seaborne
>            Priority: Major
>             Fix For: Jena 3.8.0
>
>
> Currently:
>  * TDB1: the set of {{TransactionLifecycle}} components is fixed
>  * TDB2: the set of {{TransactionComponents}} is frozen during creation of a 
> dataset.
> In order to be able to add a text index into the transaction handling, allow 
> new items to be added (carefully) into the transaction subsystem for a 
> dataset.
> This is necessary for JENA-1302.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to