[ 
https://issues.apache.org/jira/browse/JENA-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488745#comment-16488745
 ] 

ASF GitHub Bot commented on JENA-1542:
--------------------------------------

Github user rvesse commented on a diff in the pull request:

    https://github.com/apache/jena/pull/414#discussion_r190532549
  
    --- Diff: 
jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transaction/txn/TransactionCoordinator.java
 ---
    @@ -142,41 +141,56 @@ public TransactionCoordinator 
add(TransactionalComponent elt) {
          * @see #add 
          */
         public TransactionCoordinator remove(TransactionalComponent elt) {
    -        checkSetup() ;
    -        synchronized(coordinatorLock) {
    -            components.remove(elt.getComponentId()) ;
    -        }
    +        checklAllowModification() ;
    +        components.remove(elt.getComponentId()) ;
             return this ;
         }
    +    
    +    /** 
    +     * Perform modification of this {@code TransaxctionCoordiator} after 
it has been started.
    --- End diff --
    
    Typo in the `{@code }` here?


> Allow addition of transaction components after initial setup.
> -------------------------------------------------------------
>
>                 Key: JENA-1542
>                 URL: https://issues.apache.org/jira/browse/JENA-1542
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: TDB, TDB2
>    Affects Versions: Jena 3.7.0
>            Reporter: Andy Seaborne
>            Assignee: Andy Seaborne
>            Priority: Major
>             Fix For: Jena 3.8.0
>
>
> Currently:
>  * TDB1: the set of {{TransactionLifecycle}} components is fixed
>  * TDB2: the set of {{TransactionComponents}} is frozen during creation of a 
> dataset.
> In order to be able to add a text index into the transaction handling, allow 
> new items to be added (carefully) into the transaction subsystem for a 
> dataset.
> This is necessary for JENA-1302.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to