[
https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569445#comment-16569445
]
ASF GitHub Bot commented on JENA-1585:
--------------------------------------
Github user kinow commented on a diff in the pull request:
https://github.com/apache/jena/pull/456#discussion_r207734465
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuildLib.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.fuseki.build;
+
+import org.apache.jena.fuseki.FusekiConfigException;
+import org.apache.jena.fuseki.webapp.SystemState;
+import org.apache.jena.query.* ;
+import org.apache.jena.rdf.model.Literal ;
+import org.apache.jena.rdf.model.Model ;
+import org.apache.jena.rdf.model.RDFNode ;
+import org.apache.jena.rdf.model.Resource ;
+import org.apache.jena.shared.PrefixMapping ;
+import org.apache.jena.vocabulary.RDFS ;
+
+public class FusekiBuildLib {
--- End diff --
Is `FusekiBuildLib` going to replace `FusekiLib`? Would it be worth a
one/two lines comment explaining what each one does? Just so one does not
create a method in one, while the method was supposed to be in the other
class...
From a quick peek at the new classes, I think `FusekiLib` is for methods
used by Fuseki server, and `FusekiBuildLib` is more for handling
nodes/resources. In which case maybe `FusekiLib#addDataInto` methods sit in
between, but maybe could be in `FusekiBuildLib` too?
> Reorganize the Fuseki codebase to split the server engine classes from the
> webapp classes
> -----------------------------------------------------------------------------------------
>
> Key: JENA-1585
> URL: https://issues.apache.org/jira/browse/JENA-1585
> Project: Apache Jena
> Issue Type: Improvement
> Components: Fuseki
> Affects Versions: Jena 3.8.0
> Reporter: Andy Seaborne
> Assignee: Andy Seaborne
> Priority: Minor
> Fix For: Jena 3.9.0
>
>
> This is a step towards separate packages for the fuseki server engine (the
> servlets, request routing, some Jetty related support code) and the webapp
> version of Fuseki that becomes the war and standalong jar in
> jena-fuseki-server.
> This first step is code reorganization with module jena-fuseki-core to put
> the webapp java code it separate packages to the rest of the engine.
> When split, the current jena-fuseki-core tests would go into
> jena-fuseki-weabpp because they test the full server. The non-UI embeddable
> server jena-fuseki-embedded and jena-fuseki-basic already gets test in the
> integration tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
