[
https://issues.apache.org/jira/browse/JENA-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569449#comment-16569449
]
ASF GitHub Bot commented on JENA-1585:
--------------------------------------
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/456
Great stuff! Noticed a few misspellings, and also had a question about when
to use the new `FusekiBuildLib`. But other than that looks great! Thanks for
the new comments, and removing unnecessary code (e.g. that one that simply did
a `return;`). :tada:
I also realized that I submitted my review at the same time you updated the
branch with more commits I think (at least I received an e-mail from GitHub
right after that). So apologies if my comments are now out of sync. Thanks
> Reorganize the Fuseki codebase to split the server engine classes from the
> webapp classes
> -----------------------------------------------------------------------------------------
>
> Key: JENA-1585
> URL: https://issues.apache.org/jira/browse/JENA-1585
> Project: Apache Jena
> Issue Type: Improvement
> Components: Fuseki
> Affects Versions: Jena 3.8.0
> Reporter: Andy Seaborne
> Assignee: Andy Seaborne
> Priority: Minor
> Fix For: Jena 3.9.0
>
>
> This is a step towards separate packages for the fuseki server engine (the
> servlets, request routing, some Jetty related support code) and the webapp
> version of Fuseki that becomes the war and standalong jar in
> jena-fuseki-server.
> This first step is code reorganization with module jena-fuseki-core to put
> the webapp java code it separate packages to the rest of the engine.
> When split, the current jena-fuseki-core tests would go into
> jena-fuseki-weabpp because they test the full server. The non-UI embeddable
> server jena-fuseki-embedded and jena-fuseki-basic already gets test in the
> integration tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
