ASF GitHub Bot commented on JENA-1591:

Github user kinow commented on the issue:

    Rebased and amended to use my apache e-mail in the commits. Merging. 

> DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a 
> boolean/Object
> -------------------------------------------------------------------------------------------
>                 Key: JENA-1591
>                 URL: https://issues.apache.org/jira/browse/JENA-1591
>             Project: Apache Jena
>          Issue Type: Improvement
>    Affects Versions: Jena 3.8.0
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>             Fix For: Jena 3.9.0
> TransactionCoordinator's finishActiveTransaction method calls the Set method: 
> activeTransactions.remove(transaction) ;
> It stores the return value as `x`, and then checks if x == null. As Set 
> returns a boolean, it won't ever be true.
> Submitting a pull request where we actually use the boolean value.
> Another simple issue, but that I could not come up with a simple unit test, 
> sorry.

This message was sent by Atlassian JIRA

Reply via email to