[ 
https://issues.apache.org/jira/browse/JENA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577343#comment-16577343
 ] 

ASF subversion and git services commented on JENA-1591:
-------------------------------------------------------

Commit 85a5a3b4e97174e255624eed441e824d87c8304c in jena's branch 
refs/heads/master from [~brunodepau...@yahoo.com.br]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=85a5a3b ]

Merge branch 'JENA-1591'


> DBOE TransactionCoordinator#finishActiveTransaction has an invalid if with a 
> boolean/Object
> -------------------------------------------------------------------------------------------
>
>                 Key: JENA-1591
>                 URL: https://issues.apache.org/jira/browse/JENA-1591
>             Project: Apache Jena
>          Issue Type: Improvement
>    Affects Versions: Jena 3.8.0
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>             Fix For: Jena 3.9.0
>
>
> TransactionCoordinator's finishActiveTransaction method calls the Set method: 
> activeTransactions.remove(transaction) ;
> It stores the return value as `x`, and then checks if x == null. As Set 
> returns a boolean, it won't ever be true.
> Submitting a pull request where we actually use the boolean value.
> Another simple issue, but that I could not come up with a simple unit test, 
> sorry.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to