Github user rvesse commented on a diff in the pull request:

    https://github.com/apache/jena/pull/474#discussion_r221884001
  
    --- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
    @@ -39,17 +39,28 @@
                        <version>3.10.0-SNAPSHOT</version>
                </dependency>
     
    -    <!-- Jena Driver configures Log4j directly -->
    -    <dependency>
    -      <groupId>org.slf4j</groupId>
    -      <artifactId>slf4j-log4j12</artifactId>
    -    </dependency>
    +           <!-- Jena Driver configures Log4j directly -->
    +           <dependency>
    +                   <groupId>org.slf4j</groupId>
    +                   <artifactId>slf4j-log4j12</artifactId>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>log4j</groupId>
    +                   <artifactId>log4j</artifactId>
    +           </dependency>
    +
    +           <dependency>
    --- End diff --
    
    `JenaDriver` can optionally configure Log4j, this is because JDBC drivers 
can be used in contexts where the end user can't directly configure logging 
e.g. when dropped into other applications.  In those contexts users can add 
`logging=<log4j-config>` to have the driver configure logging for them.
    
    However the default behaviour is to not configure anything and all the code 
internally uses SLF4J so in environments where users can control logging 
configuration they are free to do that.  So in environments where the user 
fully controls things they can configure logging as appropriate.


---

Reply via email to