Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/474#discussion_r222233579
  
    --- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
    @@ -39,17 +39,28 @@
                        <version>3.10.0-SNAPSHOT</version>
                </dependency>
     
    -    <!-- Jena Driver configures Log4j directly -->
    -    <dependency>
    -      <groupId>org.slf4j</groupId>
    -      <artifactId>slf4j-log4j12</artifactId>
    -    </dependency>
    +           <!-- Jena Driver configures Log4j directly -->
    +           <dependency>
    +                   <groupId>org.slf4j</groupId>
    +                   <artifactId>slf4j-log4j12</artifactId>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>log4j</groupId>
    +                   <artifactId>log4j</artifactId>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>org.apache.logging.log4j</groupId>
    +                   <artifactId>log4j-api</artifactId>
    +           </dependency>
    +
    +           <!-- Intercept direct use of log4j2 -->
    +           <dependency>
    +                   <groupId>org.apache.logging.log4j</groupId>
    --- End diff --
    
    I'm unclear here. I tried with JDK10 and had to add the log4j1 dependency 
but not the log4j2 dependencies.
    
    In the code I can only find imports of `org.apache.log4j`, which is log4j1, 
not `org.apache.logging.log4j` which is log4j2.
    
    Elasticsearch does use log4j2 and Jena adds adapters theer for that.


---

Reply via email to