afs commented on issue #527: SDB Transform - improve performance of OPTIONAL, MINUS URL: https://github.com/apache/jena/pull/527#issuecomment-463137961 Yes, that's the level of tests that would set this up for long term stability. They would mean that in the future some other change somewhere else will signal that optimization has been impacted. Op.equals is deep, structural equality. Ops are immutable values. See OpBase.equalTo that has provision of comparison with bnode isomorphisms (not necessary here!) So you can write the expected output as a string and use SSE.parseOp. See TestOptimizer (SPARQL to expect algebra) and TestTransformFilterPlacement (algebra optimized to algebra, and no, I don't know why TestTransformFilterPlacement.test (String, String) isn't in a more obvious library class).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
