seaninryan commented on issue #534: [WIP] Proof of concept for prometheus 
endpoint
URL: https://github.com/apache/jena/pull/534#issuecomment-467941793
 
 
   Hi all
   
   I think I've got this to somewhere decent now
   - I've got a core dependency on `micrometer-core` and have add a module in 
extras which pulls in `micrometer-registry-prometheus`
     - so the extras module created a shaded jar that you can just drop in
   - I've created an extras servlet that maps to `$/extras/*`
     - this picks up on classes that implement `ExtraAction` which gives a path 
that gets mapped on startup. So `ActionPrometheus` (in the extras module) 
returns the string `prometheus` which means we have a mapping of 
`$/extras/prometheus`
     - I wrote it to pick up the exact path - so we might want to extend to, 
say make a url particular to a dataset or allow wildcards of its own?
     - have a look at the `ActionExtras` class... it kind of breaks with the 
conventions of other similar classes by not calling `doCommon()`... I'm not 
sure if that's a big deal but I think `/$/extras` is incompatible with 
requiring a dataset name etc. You guys will know better I guess
   - I just picked a bunch of easy to set up `MeterBinders` that seemed 
relevant. There are a couple of Jetty ones that I'd like to add but they 
require access to some Jetty objects (haven't looked too deeply) that I don't 
have access to right now
   
   Anyway you can get really nice dashboards [like 
this](https://grafana.com/dashboards/4701) for free then
   
![2019-02-27-16-52-21_1889x956](https://user-images.githubusercontent.com/13253395/53507629-23282780-3ab0-11e9-8ab5-be932c95c8cd.png)
   
   I've just zoomed out to give an overall effect... these graphs are just 
memory usage, cpu etc.
   
   It would be great if you guys could give this the once over tell me what I 
need to do to get it considered for merging to master
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to