afs commented on issue #534: [WIP] Proof of concept for prometheus endpoint URL: https://github.com/apache/jena/pull/534#issuecomment-475628676 #### Packaging Looking in more detail ... the duplication of classes in the jena-prometheus jar means the amount of new code in module `jena-promotheus` is quite small (it is local code and prometheus-registry). By my rough calculation, In Fuseki core: ``` 416K io/micrometer/micrometer-core/ 112K org/hdrhistogram/ 32K org/latencyutils/ ``` In jena-prometheus: ``` 28K io/micrometer/micrometer-registry-prometheus/ 12K jena-prometheus jar ``` (have I got that right?) Having to repackage Fuseki-full to get a WAR file or a new combined jar is an extra step for the end user. This was the step that took me the longest to get something working. The code modularity is worth it - the packaging less so IMO.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
