Hi, Note my initial idea for using it in LoggerPanel was: - to color in RED ERROR and WARNING logs - at some step be able to search in it, 2 features that RTSA offers ( http://fifesoft.com/rsyntaxtextarea/examples/example4.php) Currently it is still easier to open jmeter.log in an editor and do it but I thought being able to do it in JMeter GUI was better.
But I didn't have time to implement it and for now I think we should (I will on my side) concentrate efforts on the following items: - http://mail-archives.apache.org/mod_mbox/jmeter-dev/201410.mbox/%3ccah9fupa_kfcsdskkx-+3dsqhfhv9amapndoysnmmuvq30dv...@mail.gmail.com%3E I think that UNDO/REDO should be given some attention to make it enabled in future version, not 2.13 maybe but it would be nice. - https://issues.apache.org/bugzilla/show_bug.cgi?id=57043 - https://issues.apache.org/bugzilla/show_bug.cgi?id=57039 - https://issues.apache.org/bugzilla/show_bug.cgi?id=57040 - Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53540 By the way maybe these bugs should be mentioned in the message that shows how to enable it. I had some feedback from customers that enabled it and noticed slowdowns ( I answered these issues were known that's why feature was disabled by default), so not obvious. For 2.13 release, if you can give me some time I would like to implement Performance improvement thanks to Oleg answers on friday. I will notify if I think it takes me too much time. Regards Philippe On Sun, Jan 25, 2015 at 3:30 PM, Philippe Mouawad < [email protected]> wrote: > > > On Sun, Jan 25, 2015 at 1:20 AM, sebb <[email protected]> wrote: > >> OK to name it 2.13 and to release it. >> > > Thanks > >> >> Given that there have been some issues with using RSyntaxTextArea, I >> wonder whether what it provides for the LoggerPanel is worth the >> potential disadvantages. >> >> I have just had a look at the display, and I'm not sure it provides >> much apart from line numbering.. >> >> I can see that RSTA is beneficial for the GUI fields, but these are >> generally quite small, whereas the logging panel can grow without >> bound. >> >> At the moment the user has no choice as to whether to use it. >> >> Rather than release 2.13 and hope that the issues have been solved, I >> think it would be better to at least provide the option to disable >> RSTA for the LoggerPanel. This could be done with a property. >> >> We do not hope issues are solved , we have explanation of source of > issues and they are fixed now (1 (limit) by change in constructor, the > second by reverting to old way of adding events). > I made some tests enabling LoggerPanel and making logs huge, I didn't > notice memory leak, but other checks are welcome. > We are expecting a fix from RTSA but we can work without it. > Adding a new property does not seem to me a good idea: > - Another new one (we have for something like 237 JMETER PROPERTIES), > - adding a new one to propose a choice for customizing logger panel does > not seem suitable for me. If we are not satisfied with RTSA for this, then > let's just drop it. > > By the way making some review and documenting properties would may be a > good idea to ensure they are all useful and still up to date. Shall I open > a bugzilla for this ? > > > At least then there would be a work round if RSTA proves problematic. > > As I said, in current nightly build, issue is fixed but other commiters > double checks are welcome to be sure. > > >> >> On 24 January 2015 at 19:56, Felix Schumacher >> <[email protected]> wrote: >> > Am 24.01.2015 um 16:30 schrieb Philippe Mouawad: >> > >> >> Hello, >> >> It appears 2.12 suffers from an OOM in GUI mode : >> >> >> >> - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440 >> >> >> >> This OOM seems to be due to RSyntaxTexarea bug: >> >> >> >> - https://github.com/bobbylight/RSyntaxTextArea/issues/99 >> >> >> >> It appeared after the rework of LoggerPanel#processEvent way of >> appending >> >> event. >> >> >> >> Now that it receivs log event even when closed this OOM has more >> chances >> >> to >> >> appear. >> >> >> >> I reverted to 2.11 way of appending events to fix OOM waiting for >> answer >> >> from rsyntaxtarea project. >> >> >> >> There was also a bug in the way limit=0 was set that had no effect, I >> >> fixed >> >> it as part of the bug. >> >> >> >> There is a workaround which is to set: >> >> >> >> - jmeter.loggerpanel.enable_when_closed=false >> >> >> >> But if user opens panel, OOM will occur if lot of logs occur >> (specially if >> >> stacktraces). >> >> >> >> If we release, it cannot be named 2.12.1 because we have some "big?" >> >> features in this versions so it would not be a minor one. >> >> >> >> Regarding the frequency and impact of this bug, in our company I had 2 >> >> reports in 5 days of this OOM so I think it is not to be ignored. >> >> >> >> >> >> Thoughts ? >> >> >> > +1 to release 2.13. I don't think a we should go for 2.x.y. >> > >> > Regards >> > Felix >> > > > > -- > Cordialement. > Philippe Mouawad. > > > -- Cordialement. Philippe Mouawad.
