Thanks Felix for catching this problem before release. It's my fault, sorry for the incurred work Milamber.
Regards On Monday, November 7, 2016, Felix Schumacher < [email protected]> wrote: > Am 05.11.2016 19:31, schrieb Milamber: > >> Hello, >> >> The *second* release candidate for JMeter 3.1 (r1768251) has been >> prepared, and your votes are solicited. >> >> This release brings new features and fixes bugs. >> >> Please, test this release candidate (with load tests and/or functional >> tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the >> changes. The feedback are welcome. >> >> You can read the New and Noteworthy section with some screenshots to >> illustrate improvements and full list of changes at: >> http://home.apache.org/~milamber/jmeter-3.1RC2/docs/changes.html >> >> JMeter is a Java desktop application designed to load test functional >> behavior and measure performance. The current version is targeted at >> Java 7+. >> >> Download - Archives/hashes/sigs: >> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.1_RC2/ >> (dist revision r16849) >> >> RAT report: >> >> http://home.apache.org/~milamber/jmeter-3.1RC2/dist/rat- >> report-jmeter-3.1RC2.txt >> >> MD5 hashes of archives for this vote: >> >> 8588093fb8270f2e9e93f8991a505c20 *apache-jmeter-3.1.tgz >> 779e4b27994632f5da48654346dbf93f *apache-jmeter-3.1.zip >> b586a3146c4850f65d699ccbd1e91cbe *apache-jmeter-3.1_src.tgz >> cef081850fe148b86d7dc8ef24d5fdb3 *apache-jmeter-3.1_src.zip >> >> >> Site Docs are here: >> http://home.apache.org/~milamber/jmeter-3.1RC2/docs/ >> >> Maven staging repository is accessible here: >> https://repository.apache.org/content/repositories/orgapache >> jmeter-1012/org/apache/jmeter/ >> >> Tag: >> https://svn.apache.org/repos/asf/jmeter/tags/v3_1_RC2/ >> >> Keys are here: >> https://www.apache.org/dist/jmeter/KEYS >> >> N.B. >> To download the dependencies: "ant download_jars" >> >> To create the jars and test JMeter: "ant package test". >> >> JMeter 3.1 requires Java 7 or later to run. >> >> Some known issues and incompatible changes are listed on changes page. >> http://home.apache.org/~milamber/jmeter-3.1RC2/docs/changes. >> html#Known%20problems%20and%20workarounds >> >> >> All feedback and vote are welcome. >> >> [ ] +1 I support this release >> [ ] +0 I am OK with this release >> [ ] -0 OK, but.... >> [ x] -1 I do not support this release (please indicate why) >> > > The JSR223TestElement favours groovy a bit too much. If a script language > is given the test element will choose groovy. > > diff --git a/src/core/org/apache/jmeter/util/JSR223TestElement.java > b/src/core/org/apache/jmeter/util/JSR223TestElement.java > index 9ce4557..a9eb840 100644 > --- a/src/core/org/apache/jmeter/util/JSR223TestElement.java > +++ b/src/core/org/apache/jmeter/util/JSR223TestElement.java > @@ -104,7 +104,7 @@ public abstract class JSR223TestElement extends > ScriptingTestElement > */ > private String getScriptLanguageWithDefault() { > String lang = getScriptLanguage(); > - if (!StringUtils.isNotEmpty(lang)) { > + if (StringUtils.isNotEmpty(lang)) { > return lang; > } > return DEFAULT_SCRIPT_LANGUAGE; > > > To reproduce this bug, add a thread group with a JSR223 Sampler. Set the > samplers language to javascript and place simple valid javascript code into > it (which should be invalid groovy), like: > > var r="r"; > r; > > Run the test and look at the logs. > > I wonder how we missed this. I think I will not be able to commit the > above fix today, so if anyone else wants to; feel free. > > Regards, > Felix > > >> The vote will remain open for at least 72 hours. >> >> The PMC members please indicate the mention "(binding)" with your vote. >> >> >> Note: If the vote passes, the intention is to release the archive files >> and rename the RC tag as the release tag. >> >> Thanks in advance! >> >> Milamber >> > -- Cordialement. Philippe Mouawad.
