Am 07.11.2016 20:27, schrieb Milamber:
Thanks Felix too.
It's better to find this *before* release ;-)

I will cancel the RC2 tomorrow and start a new RC3. Last chance to
make some docs commit (or bug commits) before RC3.

I have found another (minor) problem with the printable-docs. Text that is outside of any element is not rendered. This can be seen in the changes.html and can be changed by applying the following patch:

diff --git a/xdocs/changes.xml b/xdocs/changes.xml
index cd2e698..e3c42bc 100644
--- a/xdocs/changes.xml
+++ b/xdocs/changes.xml
@@ -58,7 +58,9 @@ Summary
 <ch_section>New and Noteworthy</ch_section>

 <ch_section>Improve Report/Dashboard</ch_section>
+<p>
 The Dashboard has been improved with 3 new graphs and 1 summary table:
+</p>
 <ul>
<li>Connect Time over Time graph : <figure width="1635" height="520" image="dashboard/report_connect_time_over_time.png" ></figure></li> <li>Response Time Percentiles Over Time (successful responses) graph : <figure width="1640" height="539" image="dashboard/response_time_percentiles_over_time.png" ></figure></li> @@ -70,22 +72,32 @@ The Dashboard has been improved with 3 new graphs and 1 summary table:
 </ul>

 <ch_section>New Metrics</ch_section>
+<p>
A new <code>sent_bytes</code> metric has been introduced which reports the bytes sent to server.<br/> Another metric <code>connect_time</code> has been enabled by default in this version
+</p>

 <ch_section>Handling Big responses</ch_section>
+<p>
JMeter is now able to handle in terms of metrics responses bigger than 2GB, limit has been increased to 9223372 TB.<br/> To handle such big responses, it can also now truncate part of the response to avoid overflooding memory. See <code>httpsampler.max_bytes_to_store_per_request</code> property.
+</p>

 <ch_section>New <code>__groovy</code> function</ch_section>
+<p>
Introduce a new function <code>__groovy</code> that enables Groovy functions. This can be handy, as JavaScript can be quite slow (same for BeanShell), when used in highly concurrent test plans.
+</p>

 <ch_section>Use Groovy as default for JSR-223 elements</ch_section>
+<p>
Groovy is now set as the default language for JSR-223 elements. If you want to use another of the supported language, you have to make an explicit choice.
+</p>
<note>By default <code>Cache compiled script if available</code> is not checked by default although we advise you to check it and ensure you don't use <code>${varName}</code> syntax to access JMeter variables but <code>vars.get("varName")</code> instead.</note>

<ch_section>Formatted HTML source view in Results Tree View</ch_section>
+<p>
The HTML source code in the Results Tree View can now be viewed formatted. This is extremely useful, if the code of the webpage has been stripped of all superfluous whitespace.
+</p>
<figure width="635" height="271" image="html-formatted-tree-view.png">New formatted HTML source view</figure>

 <ch_title>Core improvements</ch_title>

This patch adds a "p" element around text.

I will apply this this evening, if noone beats me.

Regards,
 Felix


Milamber

On 07/11/2016 19:09, Philippe Mouawad wrote:
Thanks Felix for catching this problem before release.
It's my fault, sorry for the incurred work Milamber.

Regards

On Monday, November 7, 2016, Felix Schumacher <
[email protected]> wrote:

Am 05.11.2016 19:31, schrieb Milamber:

Hello,

The *second* release candidate for JMeter 3.1 (r1768251) has been
prepared, and your votes are solicited.

This release brings new features and fixes bugs.

Please, test this release candidate (with load tests and/or functional
tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the
changes. The feedback are welcome.

You can read the New and Noteworthy section with some screenshots to
illustrate improvements and full list of changes at:
http://home.apache.org/~milamber/jmeter-3.1RC2/docs/changes.html

JMeter is a Java desktop application designed to load test functional
behavior and measure performance. The current version is targeted at
Java 7+.

Download - Archives/hashes/sigs:

https://dist.apache.org/repos/dist/dev/jmeter/v3.1_RC2/
(dist revision r16849)

RAT report:

http://home.apache.org/~milamber/jmeter-3.1RC2/dist/rat-
report-jmeter-3.1RC2.txt

MD5 hashes of archives for this vote:

8588093fb8270f2e9e93f8991a505c20 *apache-jmeter-3.1.tgz
779e4b27994632f5da48654346dbf93f *apache-jmeter-3.1.zip
b586a3146c4850f65d699ccbd1e91cbe *apache-jmeter-3.1_src.tgz
cef081850fe148b86d7dc8ef24d5fdb3 *apache-jmeter-3.1_src.zip


Site Docs are here:
http://home.apache.org/~milamber/jmeter-3.1RC2/docs/

Maven staging repository is accessible here:
https://repository.apache.org/content/repositories/orgapache
jmeter-1012/org/apache/jmeter/

Tag:
https://svn.apache.org/repos/asf/jmeter/tags/v3_1_RC2/

Keys are here:
https://www.apache.org/dist/jmeter/KEYS

N.B.
To download the dependencies: "ant download_jars"

To create the jars and test JMeter: "ant package test".

JMeter 3.1 requires Java 7 or later to run.

Some known issues and incompatible changes are listed on changes page.
http://home.apache.org/~milamber/jmeter-3.1RC2/docs/changes.
html#Known%20problems%20and%20workarounds


All feedback and vote are welcome.

[  ] +1  I support this release
[  ] +0  I am OK with this release
[  ] -0   OK, but....
[ x] -1   I do not support this release (please indicate why)

The JSR223TestElement favours groovy a bit too much. If a script language
is given the test element will choose groovy.

diff --git a/src/core/org/apache/jmeter/util/JSR223TestElement.java
b/src/core/org/apache/jmeter/util/JSR223TestElement.java
index 9ce4557..a9eb840 100644
--- a/src/core/org/apache/jmeter/util/JSR223TestElement.java
+++ b/src/core/org/apache/jmeter/util/JSR223TestElement.java
@@ -104,7 +104,7 @@ public abstract class JSR223TestElement extends
ScriptingTestElement
       */
      private String getScriptLanguageWithDefault() {
          String lang = getScriptLanguage();
-        if (!StringUtils.isNotEmpty(lang)) {
+        if (StringUtils.isNotEmpty(lang)) {
              return lang;
          }
          return DEFAULT_SCRIPT_LANGUAGE;


To reproduce this bug, add a thread group with a JSR223 Sampler. Set the samplers language to javascript and place simple valid javascript code into
it (which should be invalid groovy), like:

var r="r";
r;

Run the test and look at the logs.

I wonder how we missed this. I think I will not be able to commit the
above fix today, so if anyone else wants to; feel free.

Regards,
  Felix


The vote will remain open for at least 72 hours.

The PMC members please indicate the mention "(binding)" with your vote.


Note: If the vote passes, the intention is to release the archive files
and rename the RC tag as the release tag.

Thanks in advance!

Milamber

Reply via email to