Thanks Milamber ! Maybe we should run this tool ( https://github.com/lvc/japi-compliance-checker) on JMeter 3.2 RC2 vs 3.1 to double check there are no other similar non identified issues.
Regards On Mon, Apr 3, 2017 at 9:20 PM, Milamber <milam...@apache.org> wrote: > Hello, > > I will cancel the RC2 vote and start a RC3 next Wednesday or Friday (after > the re-introduction of the removed API. cc Philippe). > > Please continue your test about RC2 to find a lot of bugs before the RC3 > ;-) > > Milamber > > > On 03/04/2017 10:45, Antonio Gomes Rodrigues wrote: > >> Hi, >> >> Like Philippe >> >> [X] I do not support this release >> >> In my opinion, we need to deprecate this API in 3.2 release and remove it >> in 3.3 >> >> Antonio >> >> 2017-04-03 7:40 GMT+02:00 Philippe Mouawad <p.moua...@ubik-ingenierie.com >> >: >> >> Hello, >>> Thanks Milamber for your work on RM for this. >>> >>> Due to issue reported my vote is: >>> >>> [X] I do not support this release >>> >>> I can fix issue if ok for you to commit in trunk. >>> >>> Regards >>> >>> On Sunday, April 2, 2017, Philippe Mouawad < >>> p.moua...@ubik-ingenierie.com> >>> wrote: >>> >>> Hello, >>>> I am to blame for this issue, sorry ! >>>> http://svn.apache.org/viewvc?rev=1783666&view=rev >>>> >>>> >>>> Regards >>>> >>>> >>>> On Sun, Apr 2, 2017 at 3:08 PM, UBIK LOAD PACK Support < >>>> supp...@ubikloadpack.com >>>> <javascript:_e(%7B%7D,'cvml','supp...@ubikloadpack.com');>> wrote: >>>> >>>> Hello, >>>>> Note this is annoying as fixing it would mean that our plugin would >>>>> only >>>>> support 3.2. >>>>> We usually try to support N and N-1 versions to allow for migration. >>>>> And this was usually the policy with JMeter releases. >>>>> >>>>> Hope you can take this into account. >>>>> Regards >>>>> >>>>> >>>>> >>>>> >>>>> On Sun, Apr 2, 2017 at 3:03 PM, UBIK LOAD PACK Support < >>>>> supp...@ubikloadpack.com >>>>> <javascript:_e(%7B%7D,'cvml','supp...@ubikloadpack.com');>> wrote: >>>>> >>>>> Hello, >>>>>> First thanks a lot for all the team for the great work on Apache >>>>>> JMeter >>>>>> and thanks to RM ! >>>>>> >>>>>> Now for this release, it appears HeaderManager API has been modified >>>>>> in >>>>>> a breaking and undocumented way: >>>>>> This method: >>>>>> >>>>>> - https://github.com/apache/jmeter/blob/v3_1/src/protocol/http >>>>>> /org/apache/jmeter/protocol/http/control/HeaderManager.java#L268 >>>>>> <https://github.com/apache/jmeter/blob/v3_1/src/protocol/ >>>>>> >>>>> http/org/apache/jmeter/protocol/http/control/HeaderManager.java#L268> >>> >>>> Has been modified: >>>>>> >>>>>> - https://github.com/apache/jmeter/blob/v3_2_RC2/src/protocol/ >>>>>> http/org/apache/jmeter/protocol/http/control/ >>>>>> >>>>> HeaderManager.java#L234 >>> >>>> <https://github.com/apache/jmeter/blob/v3_2_RC2/src/ >>>>>> >>>>> protocol/http/org/apache/jmeter/protocol/http/control/ >>> HeaderManager.java#L234> >>> >>>> >>>>>> This would unfortunately break our plugin. >>>>>> >>>>>> Is is possible to reintroduce this method and make it deprecated ? >>>>>> >>>>>> Thanks >>>>>> Regards >>>>>> >>>>>> UbikLoadPack Team >>>>>> >>>>>> >>>>>> >>>>>> On Sun, Apr 2, 2017 at 12:45 PM, Rainer Jung <rainer.j...@kippdata.de >>>>>> <javascript:_e(%7B%7D,'cvml','rainer.j...@kippdata.de');>> wrote: >>>>>> >>>>>> Am 01.04.2017 um 18:23 schrieb Milamber: >>>>>>> >>>>>>> Hello, >>>>>>>> >>>>>>>> The second release candidate for JMeter 3.2 (r1789808) has been >>>>>>>> prepared, and your votes are solicited. >>>>>>>> >>>>>>>> This release brings new features and fixes bugs. >>>>>>>> >>>>>>>> Please, test this release candidate (with load tests and/or >>>>>>>> >>>>>>> functional >>> >>>> tests) using Java 8 on Linux/Windows/Mac OS, especially on the >>>>>>>> >>>>>>> changes. >>> >>>> The feedback are welcome. >>>>>>>> >>>>>>>> You can read the New and Noteworthy section with some screenshots to >>>>>>>> illustrate improvements and full list of changes at: >>>>>>>> http://home.apache.org/~milamber/jmeter-3.2RC2/docs/changes.html >>>>>>>> >>>>>>>> JMeter is a Java desktop application designed to load test >>>>>>>> functional >>>>>>>> behavior and measure performance. The current version is targeted at >>>>>>>> Java 8+. >>>>>>>> >>>>>>>> Download - Archives/hashes/sigs: >>>>>>>> >>>>>>>> https://dist.apache.org/repos/dist/dev/jmeter/v3.2_RC2/ >>>>>>>> (dist revision r18998) >>>>>>>> >>>>>>>> RAT report: >>>>>>>> >>>>>>>> http://home.apache.org/~milamber/jmeter-3.2RC2/dist/rat-repo >>>>>>>> rt-jmeter-3.2RC2.txt >>>>>>>> >>>>>>>> >>>>>>>> MD5 hashes of archives for this vote: >>>>>>>> >>>>>>>> cfa8095f9c42208eb70caa6a0074558a *apache-jmeter-3.2.tgz >>>>>>>> 5d49a7cf94ce4dfebc68ab35f6f686d8 *apache-jmeter-3.2.zip >>>>>>>> 2dad5f6366647c93f822c87e64ff24ac *apache-jmeter-3.2_src.tgz >>>>>>>> 43f4ea27110efb23032e708e44dafe55 *apache-jmeter-3.2_src.zip >>>>>>>> >>>>>>>> Site Docs are here: >>>>>>>> http://home.apache.org/~milamber/jmeter-3.2RC2/docs/ >>>>>>>> >>>>>>>> Maven staging repository is accessible here: >>>>>>>> https://repository.apache.org/content/repositories/orgapache >>>>>>>> jmeter-1016/org/apache/jmeter/ >>>>>>>> >>>>>>>> >>>>>>>> Tag: >>>>>>>> https://svn.apache.org/repos/asf/jmeter/tags/v3_2_RC2/ >>>>>>>> >>>>>>>> Keys are here: >>>>>>>> https://www.apache.org/dist/jmeter/KEYS >>>>>>>> >>>>>>>> N.B. >>>>>>>> To download the dependencies: "ant download_jars" >>>>>>>> >>>>>>>> To create the jars and test JMeter: "ant package test". >>>>>>>> >>>>>>>> JMeter 3.2 requires Java 8 or later to run. >>>>>>>> >>>>>>>> Some known issues and incompatible changes are listed on changes >>>>>>>> >>>>>>> page. >>> >>>> http://home.apache.org/~milamber/jmeter-3.2RC2/docs/changes. >>>>>>>> html#Known%20problems%20and%20workarounds >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> All feedback and vote are welcome. >>>>>>>> >>>>>>>> [XX] +1 I support this release >>>>>>>> [ ] +0 I am OK with this release >>>>>>>> [ ] -0 OK, but.... >>>>>>>> [ ] -1 I do not support this release (please indicate why) >>>>>>>> >>>>>>>> The vote will remain open for at least 72 hours. >>>>>>>> >>>>>>>> The PMC members please indicate the mention "(binding)" with your >>>>>>>> >>>>>>> vote. >>> >>>> >>>>>>>> Note: If the vote passes, the intention is to release the archive >>>>>>>> >>>>>>> files >>> >>>> and rename the RC tag as the release tag. >>>>>>>> >>>>>>>> Thanks in advance! >>>>>>>> >>>>>>>> +1 (binding), thanks for RM. >>>>>>> >>>>>>> Details: >>>>>>> >>>>>>> - MD5 OK >>>>>>> - signatures OK >>>>>>> - key in KEYS file >>>>>>> - tgz and zip for src and bin consistent >>>>>>> - svn and tgz/zip mostly consistent >>>>>>> - file bin/utility.groovy missing in src tgz/zip >>>>>>> IMHO not a showstopper, fixed in r1789871 after RC2. >>>>>>> Note: the missing file breaks the ability to run >>>>>>> "ant distribution" from a src tgz/zip. >>>>>>> I think this must have already been the case for >>>>>>> 3.1 (untested). >>>>>>> - some files with name "*cp1252*" contain some binary differences >>>>>>> between svn and zip. >>>>>>> Example: file test/resources/org/apache/jmet >>>>>>> er/protocol/jms/sampler/render/cp1252.txt >>>>>>> in svn is 3 bytes hex 0xe9 0xe8 0x80 >>>>>>> and in zip 6 bytes hex 0xef 0xbf 0xbd 0xef 0xbf 0xbd >>>>>>> - files bin/report-template/*/*/*/make.sh are not executable >>>>>>> (not in svn and not in any bin or src archive) >>>>>>> - builds fine except: >>>>>>> - needed to disable class RenderInBrowser.java, >>>>>>> because Oracle doesn't support JavaFX for Solaris >>>>>>> - build result looks consistent with distribution, except for >>>>>>> - some ordering in javadoc (expected) >>>>>>> - binary jar files (expected) >>>>>>> - no Javadoc warnings >>>>>>> - new dependencies (expected) >>>>>>> - ran the tests (but only with java.awt.headless) without failures >>>>>>> - needed to adjust the 500ms test execution time margin in >>>>>>> TestSchedulerWithTimer.jmx (slow test system) >>>>>>> - I have not checked the staging repository. >>>>>>> - I have not checked the rat report >>>>>>> >>>>>>> Build and tests were done using Java 1.8.0_121, OS was Solaris 10 >>>>>>> >>>>>> Sparc. >>> >>>> Regards, >>>>>>> >>>>>>> Rainer >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>> -- >>>> Cordialement. >>>> Philippe Mouawad. >>>> >>>> >>>> >>>> -- >>> Cordialement. >>> Philippe Mouawad. >>> Ubik-Ingénierie >>> >>> UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/> >>> >>> UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack> >>> >>> > -- Cordialement. Philippe Mouawad.
