Hello, It looks nice indeed. But the glitches for now seem blocking no ? Regards
On Fri, Feb 14, 2020 at 7:57 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > >Yes, it is looking really nice. > > OK. I've tried it, and it seems to work, however, there are glitches :( > > The most interesting bit is jxlayer-3.0.4.jar dependency. > AFAIK the library was initiated at http://swinglabs.org/ which is no > longer > available. > The jar file does not bundle the license text. > I don't think the original repository is alive. > > I guess the license of the artifact is BSD-3-Clause (==> it requires to > reproduce the copyright header), > so technically speaking we must somehow resurrect the copyright owner if we > want to include that dependency :) > > I'm not that good at resurrection, however, it looks like this looks ok: > > https://github.com/tsachev/jgnash/blob/25a5ad1f9349cf9f2849509c09a24f8b1fa3cbf5/jgnash-resources/src/main/resources/jgnash/resource/html/en/jxlayer-license.html > > ---- > > Here's a PR with minimal change to make it fly: > https://github.com/apache/jmeter/pull/556 > > I've filed a couple of issues to darklaf as well. > > Vladimir > -- Cordialement. Philippe Mouawad.
