vlsi commented on a change in pull request #603:
URL: https://github.com/apache/jmeter/pull/603#discussion_r449578814
##########
File path:
src/components/src/main/java/org/apache/jmeter/visualizers/JSR223Listener.java
##########
@@ -38,7 +38,7 @@
*/
@TestElementMetadata(labelResource = "displayName")
public class JSR223Listener extends JSR223TestElement
- implements Cloneable, SampleListener, TestBean, Visualizer {
+ implements Cloneable, JMeterThreadBoundSampleListener, TestBean,
Visualizer {
Review comment:
I do not follow that. Do you mean that every custom listener
implementation must be updated and recompiled with
JMeterThreadBoundSampleListener?
If that is the case, I don't think the PR is acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
