pmouawad commented on a change in pull request #603:
URL: https://github.com/apache/jmeter/pull/603#discussion_r449582063
##########
File path:
src/components/src/main/java/org/apache/jmeter/visualizers/JSR223Listener.java
##########
@@ -38,7 +38,7 @@
*/
@TestElementMetadata(labelResource = "displayName")
public class JSR223Listener extends JSR223TestElement
- implements Cloneable, SampleListener, TestBean, Visualizer {
+ implements Cloneable, JMeterThreadBoundSampleListener, TestBean,
Visualizer {
Review comment:
No as I consider that if it does not implement the new interfaces, it
should work as currently , so be executed in JMeterThread.
But I added this interface to identify explicitly Listeners that have this
constraint vs others. To be frank I (re) discovered this thanks to tests
failures when we introduced the queue and it took me some time to understand
the problem.
So by clearly identifying this requirement of some listeners it is now
obvious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
