pmouawad commented on pull request #603: URL: https://github.com/apache/jmeter/pull/603#issuecomment-655741122
> Please avoid naming like `JMeterThreadBoundSampleListener`. > > 1. The annotation is in `org.jmeter....` package, so there's no need to duplicate `jmeter` ok > > 2. Why do you have `SampleListener` there? Is the annotation only for listeners? Yes for now > > 3. Why do you have two annotations instead of a single annotation with an enum property? Ok , give me a name to avoid another round trip ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
