[GitHub] [jmeter] weisJ opened a new pull request #617: Bug 64711 - Use theme from darklaf extensions for RSyntaxTextArea.

Tue, 08 Sep 2020 06:58:11 -0700 


weisJ opened a new pull request #617:
URL: https://github.com/apache/jmeter/pull/617


   ## Description
   Fixes [bug 64711](https://bz.apache.org/bugzilla/show_bug.cgi?id=64711)
   
   ## Motivation and Context
   As described in the issue in some darklaf themes text was hard or impossible 
to read.
   Darklaf provides specialized themes for RSyntaxTextArea matching the 
corresponding darklaf theme.
   
   This PR also fixes an issue where the theme isn't applied to the gutter of 
the text area the first time because
   the theme is installed before the gutter exists (i.e. before the text area 
has been added to a scroll pane).
   
   ## How Has This Been Tested?
   I manually checked that the text is readable with each theme.
   All non darklaf Lafs aren't affected by this change.
   
   ## Screenshots (if appropriate):
   
![darcula_scheme](https://user-images.githubusercontent.com/31143295/92486017-eb915400-f1eb-11ea-91f4-f783ab80b258.png)
   
![one_dark_scheme](https://user-images.githubusercontent.com/31143295/92486025-ecc28100-f1eb-11ea-9807-4cb03d52916a.png)
   
![solarized_dark_scheme](https://user-images.githubusercontent.com/31143295/92486027-ed5b1780-f1eb-11ea-8b78-c4c1740923fc.png)
   
![solarized_light_scheme](https://user-images.githubusercontent.com/31143295/92486029-ed5b1780-f1eb-11ea-9776-12b82ae4a455.png)
   
![high_contrast_dark_scheme](https://user-images.githubusercontent.com/31143295/92486030-edf3ae00-f1eb-11ea-8fb0-98508e516796.png)
   
![intellij_scheme](https://user-images.githubusercontent.com/31143295/92486033-edf3ae00-f1eb-11ea-8b38-a482c0324e94.png)
   
   ## Types of changes
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that 
apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here 
to help! -->
   - [x] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to