vlsi commented on a change in pull request #617:
URL: https://github.com/apache/jmeter/pull/617#discussion_r485165022
##########
File path:
src/core/src/main/java/org/apache/jmeter/gui/util/JSyntaxTextArea.java
##########
@@ -44,20 +49,27 @@
public class JSyntaxTextArea extends RSyntaxTextArea {
private static final long serialVersionUID = 211L;
- private static final Logger log =
LoggerFactory.getLogger(JSyntaxTextArea.class);
+ private static final Logger log =
LoggerFactory.getLogger(JSyntaxTextArea.class);
+ private static final Theme DARKLAF_THEME = new DarklafRSyntaxTheme();
Review comment:
This line seems to cause `HeadlessException`, see
https://travis-ci.org/github/apache/jmeter/jobs/725243535#L844
Is static theme really needed here?
```
java.lang.ExceptionInInitializerError
at
org.apache.jmeter.assertions.jmespath.gui.JMESPathAssertionGui.buildPanel(JMESPathAssertionGui.java:78)
at
org.apache.jmeter.assertions.gui.JSONPathAssertionGui.init(JSONPathAssertionGui.java:71)
at
org.apache.jmeter.assertions.gui.JSONPathAssertionGui.<init>(JSONPathAssertionGui.java:63)
at
org.apache.jmeter.assertions.jmespath.gui.JMESPathAssertionGui.<init>(JMESPathAssertionGui.java:59)
at
org.apache.jmeter.assertions.jmespath.gui.JMESPathAssertionGuiTest.testInit(JMESPathAssertionGuiTest.java:28)
Caused by: java.awt.HeadlessException
at
java.desktop/javax.swing.text.JTextComponent.checkDragEnabled(JTextComponent.java:698)
at
java.desktop/javax.swing.text.JTextComponent.setDragEnabled(JTextComponent.java:692)
at org.fife.ui.rtextarea.RTextArea.init(RTextArea.java:918)
at
org.fife.ui.rsyntaxtextarea.RSyntaxTextArea.init(RSyntaxTextArea.java:1988)
at
org.fife.ui.rtextarea.RTextAreaBase.<init>(RTextAreaBase.java:82)
at org.fife.ui.rtextarea.RTextArea.<init>(RTextArea.java:188)
at
org.fife.ui.rsyntaxtextarea.RSyntaxTextArea.<init>(RSyntaxTextArea.java:351)
at
com.github.weisj.darklaf.extensions.rsyntaxarea.DarklafRSyntaxTheme.<init>(DarklafRSyntaxTheme.java:40)
at
org.apache.jmeter.gui.util.JSyntaxTextArea.<clinit>(JSyntaxTextArea.java:54)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
