FSchumacher opened a new pull request #700:
URL: https://github.com/apache/jmeter/pull/700
## Description
Try to replace usage of Oro Regex implementation by Java Regex
implementation. This is done by adding a property to let the user switch
between the two. Default is to use the old Oro based one.
This is not finished. There are not all occurrences enhanced with the
switch. A lot of it feels like a hack, as much code has been duplicated.
I thought about adding some interfaces to hide the Oro and Java Regex
implementations behind, but currently I believe it would be overengineered. But
maybe someone has a good idea to make this code less hacky.
## Motivation and Context
The Oro library has been unmaintained for years and is feature-wise behind
the built-in Java Regex implementation. To make a smooth transition from Oro to
the Java built-in implementation the plan is to
* make switching possible while defaulting to the old one
* deprecate the usage of the old one and switching the default to the new one
* removing the old implementation
Every step should be made with at least one release in between.
Discussed in [Bug
57672](https://bz.apache.org/bugzilla/show_bug.cgi?id=57672) and [Bug
65883](https://bz.apache.org/bugzilla/show_bug.cgi?id=65883)
## How Has This Been Tested?
Tests were run with the default setting (Oro Regex) and some manual tests
with the setting `jmeter.use_java_regex` to `true`.
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate
-->
- New feature (non-breaking change which adds functionality)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that
apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
