FSchumacher commented on pull request #700:
URL: https://github.com/apache/jmeter/pull/700#issuecomment-1049047914


   > > If we would like to be more flexible, the simplistic approach
   > 
   > `jmeter.regex.engine=oro|java` does not require changing the 
implementation.
   > 
   > What I mean is primitive values, especially `boolean` are quite often a 
poor choice for an API. In many cases, it is hard to understand what `true` and 
`false` means.
   > 
   > See https://twitter.com/lukaseder/status/1443527683720286209
   > 
   > On the other hand, if the only values are `oro` and `java`, then it is way 
easier to understand what does the switch flip.
   
   I am not really against using a more flexible approach, but I will first try 
to finish the classes left :)
   
   Giving the users more choice, will let more room for misspellings, though :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to