Hello, Looks good to me. Let's do another RC with this. Regards On Wed, Mar 16, 2022 at 6:30 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote:
> >Could we make the setting java version dependant ? > > By default, the setting would be commented in jmeter.properties. > Then, the code would use the appropriate default value according to Java > version. > > So I suggest changing > > https://github.com/apache/jmeter/blob/53a992c8179f0f64fe1993df34bda6594856cf5e/src/jorphan/src/main/java/org/apache/jorphan/gui/ui/KerningOptimizer.java#L48 > > into something like maxLengthWithKerning = currentJava < 17 ? -1 : 10000; > > Vladimir > > > ср, 16 мар. 2022 г. в 20:25, Philippe Mouawad < > p.moua...@ubik-ingenierie.com > >: > > > Could we make the setting java version dependant ? > > If it’s worth it as it will introduce additional config complexity > > > > Regards > > On Wednesday, March 16, 2022, Vladimir Sitnikov < > > sitnikov.vladi...@gmail.com> > > wrote: > > > > > >I would say, that my issue is not a regression and therefore should be > > not > > > a blocker. > > > > > > There might be a regression like: "new setting caused activating > kerning > > > for texts smaller than 10K" (or whatever is the default). > > > So if previously the kerning was always disabled, the new option might > > > unexpectedly activate it. > > > > > > My assumption was that "it should not hurt since the text is only 10K", > > > however, in reality, it looks like even short texts cause slowness > > > for the old JDK. > > > > > > So I'm inclined to make the default 0 (always disable kerning in > response > > > text areas) for Java <17. > > > WDYT? > > > > > > Vladimir > > > > > > > > > -- > > Cordialement > > Philippe M. > > Ubik-Ingenierie > > > -- Regards Ubik Load Pack <http://ubikloadpack.com> Team Follow us on Twitter <http://twitter.com/ubikloadpack> Cordialement L'équipe Ubik Load Pack <http://ubikloadpack.com> Suivez-nous sur Twitter <http://twitter.com/ubikloadpack>
