FSchumacher commented on code in PR #5812:
URL: https://github.com/apache/jmeter/pull/5812#discussion_r1174595918


##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java:
##########
@@ -316,9 +322,10 @@ public static Map<String, String[]> getQueryMap(String 
query) {
                 System.arraycopy(known, 0, tmp, 0, known.length);
                 known = tmp;
             }
-            map.put(name, known);
+            if (validNameAndValue) {

Review Comment:
   Maybe it is easier to use `continue` in case `paramSplit.length == 1`
   Then we would have something like:
   ```java
   String[] paramSplit = param.split("=");
   if (paramSplit.length == 1) {
       continue; // skip in case, we have no key and value-pair
   }
   String name = decodeQuery(paramSplit[0]);
   ...
   // no special handling for single `=` char needed from here
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to