milamberspace commented on code in PR #5812:
URL: https://github.com/apache/jmeter/pull/5812#discussion_r1174554672
##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java:
##########
@@ -287,10 +287,16 @@ public static Map<String, String[]> getQueryMap(String
query) {
String[] params = query.split(PARAM_CONCATENATE);
for (String param : params) {
String[] paramSplit = param.split("=");
- String name = decodeQuery(paramSplit[0]);
+ String name = null;
+ boolean validNameAndValue = true;
Review Comment:
I prefer keep the intermediate variable validNameAndValue, seems bring a
better readness of the code (IMHO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
