[GitHub] [jmeter] vlsi commented on a diff in pull request #5761: Add new properties for test plan external configuration serialize, functional tearDown

[via GitHub]

vlsi commented on code in PR #5761:
URL: https://github.com/apache/jmeter/pull/5761#discussion_r1180256462


##########
src/core/src/main/java/org/apache/jmeter/testelement/TestPlan.java:
##########
@@ -82,12 +85,23 @@ public void prepareForPreCompile()
     }
 
     /**
-     * Fetches the functional mode property
-     *
+     * Fetches the functional mode property<br>
+     * Could be change for no-GUI test with jmeter property: {@code 
PROP_FUNCTIONAL_MODE}
      * @return functional mode
      */
     public boolean isFunctionalMode() {
-        return getPropertyAsBoolean(FUNCTIONAL_MODE);
+        boolean functionalModeDefault = getPropertyAsBoolean(FUNCTIONAL_MODE);
+        log.debug("functionalModeDefault=" + functionalModeDefault);
+        boolean functionalModeReturn = functionalModeDefault;
+        if (isNonGui()) {
+            String propFunctionalModeProperty = 
JMeterUtils.getProperty(PROP_FUNCTIONAL_MODE);
+            if (propFunctionalModeProperty != null) {
+                functionalModeReturn = 
JMeterUtils.getPropDefault(PROP_FUNCTIONAL_MODE, functionalModeDefault);
+                log.info("Change with property " + PROP_FUNCTIONAL_MODE + ", 
value=" + functionalModeReturn);

Review Comment:
   This will be visible to the end users.  What does `Change with property` 
mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org