vdaburon commented on code in PR #5761:
URL: https://github.com/apache/jmeter/pull/5761#discussion_r1183727203
##########
src/core/src/main/java/org/apache/jmeter/testelement/TestPlan.java:
##########
@@ -82,12 +85,23 @@ public void prepareForPreCompile()
}
/**
- * Fetches the functional mode property
- *
+ * Fetches the functional mode property<br>
+ * Could be change for no-GUI test with jmeter property: {@code
PROP_FUNCTIONAL_MODE}
* @return functional mode
*/
public boolean isFunctionalMode() {
- return getPropertyAsBoolean(FUNCTIONAL_MODE);
+ boolean functionalModeDefault = getPropertyAsBoolean(FUNCTIONAL_MODE);
+ log.debug("functionalModeDefault=" + functionalModeDefault);
+ boolean functionalModeReturn = functionalModeDefault;
+ if (isNonGui()) {
+ String propFunctionalModeProperty =
JMeterUtils.getProperty(PROP_FUNCTIONAL_MODE);
+ if (propFunctionalModeProperty != null) {
+ functionalModeReturn =
JMeterUtils.getPropDefault(PROP_FUNCTIONAL_MODE, functionalModeDefault);
+ log.info("Change with property " + PROP_FUNCTIONAL_MODE + ",
value=" + functionalModeReturn);
Review Comment:
Changed with proposal modifications log message for end user
jmeter.bat -n -Jjmeter.test_plan.functional_mode=true
-Jjmeter.test_plan.serialize_threadgroups=true
-Jjmeter.test_plan.tearDown_on_shutdown=true -t
..\test_plan_change_mode_std_v02.jmx
In jmeter.log
2023-05-03 15:54:26,048 INFO o.a.j.t.TestPlan: Overriding the value of
"Functional Test Mode" with property jmeter.test_plan.functional_mode value=true
2023-05-03 15:54:26,048 INFO o.a.j.t.TestPlan: Overriding the value of "Run
Thread Groups consecutively (serialize thread groups)" with property
jmeter.test_plan.serialize_threadgroups value=true
...
2023-05-03 15:54:26,055 INFO o.a.j.t.TestPlan: Overriding the value of "Run
tearDown Thread Groups after shutdown of main threads" with property
jmeter.test_plan.tearDown_on_shutdown value=true
2023-05-03 15:54:26,059 INFO o.a.j.e.StandardJMeterEngine: Running the test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
