vdaburon commented on code in PR #6379:
URL: https://github.com/apache/jmeter/pull/6379#discussion_r1862187885
##########
src/jorphan/src/main/kotlin/org/apache/jorphan/gui/JEditableCheckBox.kt:
##########
@@ -105,6 +107,8 @@ public open class JEditableCheckBox(
private val checkbox: JCheckBox = JCheckBox(label).apply {
val cb = this
+ cb.setBorderPainted(true)
+ cb.setBorder(BorderFactory.createLineBorder(Color(51, 204, 255))) //
Very light blue
Review Comment:
I never write Kotlin code and i can't code correctly read property in
jmeter.properties or user.properties with
var propBorderColer =
JMeterUtils.getResStringDefault("JEditableCheckBox.border.color","51,204,255")
I get an error "Adding dependency on module 'jmeter.src.core.main' will
introduce circular dependency between modules 'jmeter.src.core.main' and
'jmeter.src.jorphan.main'. Add dependency anyway?"
Could be code this external configuration ?
the border color could be a new JMeter property likes :
RGB Color:
JEditableCheckBox.border.color=51,204,255
or standard Color:
JEditableCheckBox.border.color=ORANGE
Regards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
