vlsi commented on code in PR #6379:
URL: https://github.com/apache/jmeter/pull/6379#discussion_r1862439776
##########
src/jorphan/src/main/kotlin/org/apache/jorphan/gui/JEditableCheckBox.kt:
##########
@@ -105,6 +107,8 @@ public open class JEditableCheckBox(
private val checkbox: JCheckBox = JCheckBox(label).apply {
val cb = this
+ cb.setBorderPainted(true)
+ cb.setBorder(BorderFactory.createLineBorder(Color(51, 204, 255))) //
Very light blue
Review Comment:
What I mean is that `orange` might not work for all the color themes, so it
should be rather something like "accent color" which is declared separately for
each look and feel. I am not sure if `jmeter.properties` can configure
different values for different look and feels.
This makes adding new colors hard, so we should rather try reusing the
existing color resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
