rmannibucau commented on a change in pull request #39: Deserialization of primitives URL: https://github.com/apache/johnzon/pull/39#discussion_r271666545
########## File path: johnzon-mapper/src/test/java/org/apache/johnzon/mapper/ObjectTypeTest.java ########## @@ -205,8 +207,8 @@ public void writeJson(Dog instance, MappingGenerator mappingGenerator) { } @Override - public Dog fromJson(JsonObject jsonObject, Type targetType, MappingParser parser) { - String javaType = jsonObject.getString("//javaType"); + public Dog fromJson(JsonValue jsonObject, Type targetType, MappingParser parser) { + String javaType = ((JsonObject) jsonObject).getString("//javaType"); Review comment: asJsonObject() ;) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services