rmannibucau commented on a change in pull request #39: Deserialization of primitives URL: https://github.com/apache/johnzon/pull/39#discussion_r271666417
########## File path: johnzon-mapper/src/main/java/org/apache/johnzon/mapper/ObjectConverter.java ########## @@ -39,7 +40,7 @@ private ObjectConverter() { } public interface Reader<T> extends MapperConverter { - T fromJson(JsonObject jsonObject, Type targetType, MappingParser parser); + T fromJson(JsonValue jsonValue, Type targetType, MappingParser parser); Review comment: maybe send a note about that on the list, it is a public API so not sure we want to break it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services