rmannibucau commented on issue #50: JOHNZON-272 Incorrect EOL created on Windows URL: https://github.com/apache/johnzon/pull/50#issuecomment-534601310 Even if my past experience tend to join @cyberphone on the state (my first years of work were on windows and standard - where I was working - was already \n for any java source file and I never worked on a single project not using that since), I agree with @mkarg it is a choice for its own code. Now here we generate sources for build and source inclusion (for maven auto download sources feature of _IDE_), not for editing so should we make it configurable or not is the only question IMHO and not convinced it is that critical on my side but happy to add a config param if it helps anyone (and it is a small detail of the project, we don't need to take that much time ;)).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services