rmannibucau commented on issue #50: JOHNZON-272 Incorrect EOL created on Windows URL: https://github.com/apache/johnzon/pull/50#issuecomment-534660852 @mkarg test will not test with the doc change since it builds well on linux as well - wouldn't have been merged otherwise ;). The advantage to update the doc is nobody can encounter the case you got which is not a case we take into account because we (wrongly it seems ;)) assumed all the universe was using the setup Anders mentionned. Now no issue to keep it like that too since we didn't get windows user complains before even if some built/contributed to the project already (guess git was correctly configured to use the common \n as EOL). Alternatively we can add a .gitattributes (like https://github.com/Talend/component-runtime/blob/288b4b2854e59f6d1de7128f188fddd514e9d65d/.gitattributes) which would have prevented your issue to happen. Can be simpler after all. Wdyt?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
