mkarg commented on issue #50: JOHNZON-272 Incorrect EOL created on Windows URL: https://github.com/apache/johnzon/pull/50#issuecomment-534657037 @rmannibucau You call it a regression, I call it the sole correct fix for a severe bug. We simply have completely diametrical views on this topic (and both are equally valid from within each other's universe). As it seems we cannot find a concensus on this topic, so it makes no sense that we spend any more time into this. I'm good with keeping Johnzon being buggy in this regard and step forward to fix other issues. BTW, I still do not see what you want to gain with the doc change. The `master` branch currently *passes* all tests on Windows *with* git performing its default strategy on Windows (= add CR). So if you change the docs, you simply make things worse, as then the test will *fail* again.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
