mkarg commented on issue #50: JOHNZON-272 Incorrect EOL created on Windows URL: https://github.com/apache/johnzon/pull/50#issuecomment-534668791 @rmannibucau Sigh - Agreed after reading the Java Langage Specification (for those who care: It says that Java source files MUST end on LF or CR LF or CR, which explicitly means that EOLs other than that MUST NOT be used, which means my code in PR #50 will fail on those OS's having other line separators) -- So I MUST close this PR as invalid. As apparently it is Johnzon's explicit intention to have that particular file being untouched and encoded explicitly with LF, there must not be a *general* doc change nor a *general* .gitattribute, but just a .gitattribute for this single file in the Johnzon repo -- all other files must stay under the control of the local OS's / local user's decision. But as 45408012b5ded708134d6e43ae587d0645b64f37 actually fixes the same problem, I cannot see the benefit *unless* you undo that commit. So is *replacing that commit* what you prose? Just to make me understand your actual intention.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
