Hi Justin,

We tend to bypass dev dist area for nexus based releases since we grab the
artifact from nexus so it is as error prone to set up the dev dist area
than not doing it for such releases and at the end the important part is to
synchronize the prod area and not the dev one which is only up for the time
of vote (as the staging repo). I can update it if absolutely required but
I'm not sure what would be the rational to do it (happy to discuss it in
another thread btw).

Fiexd the header and NOTICE year for next release - header was just my
default template in my IDE but was not intended to be pushed like that, not
a big deal for the release. Thanks a lot to have caught it!
About Joni, you are right, it is a dependency and we don't bundle it in
sources but some usage requires end user to import it, thought it was saner
to keep it mentionned here but happy to drop it for next release too if
everybody agrees.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le lun. 30 sept. 2019 à 15:00, Justin Mclean <jus...@classsoftware.com> a
écrit :

> Hi,
>
>  A coueple of other minor issues:
> - year in NOTICE need updating
> - This file is not mentioned in LICENSE [1].  It’s ALv2 so it not required
> to be listed, but it’s a good idea if it is.
> - Joni (MIT licensed) is mentioned in LICENSE but from a quick glance it
> seems to be a dependancy rather than bundled in the source release. Is this
> correct?
>
> Thanks,
> Justin
>
>
> 1.
> ./johnzon-1.2.1/johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/GenericAdapterTest.java
>
>

Reply via email to