rmannibucau commented on a change in pull request #56: add a ClientBuilder 
service already prepared with json
URL: https://github.com/apache/johnzon/pull/56#discussion_r355215682
 
 

 ##########
 File path: johnzon-osgi/src/main/java/org/apache/johnzon/osgi/Activator.java
 ##########
 @@ -90,6 +133,20 @@ public void start(BundleContext context) throws Exception {
                     )
                 )
             ),
+            ignore(
+                
highest(serviceReferences(ClientBuilder.class)).flatMap(OSGi::prototypes).map(
+                    serviceObjects -> new JsonClientBuilderFactory(context, 
serviceObjects)
+                ).flatMap(
+                    factory -> register(
 
 Review comment:
   Looks wrong in a json layer to register a jaxrs component, should stay in 
jaxrs whiteboard which should pull providers as per jaxrs spec imho, wdyt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to