rmannibucau commented on a change in pull request #56: add a ClientBuilder 
service already prepared with json
URL: https://github.com/apache/johnzon/pull/56#discussion_r355270169
 
 

 ##########
 File path: johnzon-osgi/pom.xml
 ##########
 @@ -101,6 +101,11 @@
       <groupId>org.apache.geronimo.specs</groupId>
       <artifactId>geronimo-jsonb_1.0_spec</artifactId>
     </dependency>
+    <dependency>
 
 Review comment:
   Jsonp comes with jsonb so all good without jaxrs - if not we must fix it in 
jsonb module.
   Also note jaxrs module is about johnzon mapper jaxrs integration, not 
anything else, and is pre-jsonb time.
   
   Issue is not if they are used but their transitivity.
   If you make the scope provided then it would be ok but will require tests 
ensjring it stays provided in the long term.
   
   Hope it makes sense

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to