dblevins commented on PR #84:
URL: https://github.com/apache/johnzon/pull/84#issuecomment-1105388280
I've updated the code to remove the casting. On formatting, I'd need some
pointers on what should be updated as the checkstyle passed.
There is a call to `generator.close()` in the `get()` method in the Snippet
class. If you're thinking of something else, let me know and I can adjust.
FYI, none of the existing `toString()` methods close their generators.
-
https://github.com/apache/johnzon/blob/v1.2.16/johnzon-core/src/main/java/org/apache/johnzon/core/JsonObjectImpl.java#L145-L156
-
https://github.com/apache/johnzon/blob/v1.2.16/johnzon-core/src/main/java/org/apache/johnzon/core/JsonArrayImpl.java#L165-L176
I can send a separate PR for that if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
