rmannibucau commented on PR #84: URL: https://github.com/apache/johnzon/pull/84#issuecomment-1107911497
Second constructor is only used in test this is why i would drop it from main code since we will never want to allow its usage. The max setting is also wrong due to the usage we do I think (this is not output buffer size but token one). For close we must find a way to call it once and it should be fine with autocloseable so I suspect buffer was buggy. Last thing is the bug for primitive we should fix since truncation should be respected there too, no passthrough IMHO ;). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
