jungm opened a new pull request, #110:
URL: https://github.com/apache/johnzon/pull/110

   Fixes the currently failing JSON-P 2.1 TCK tests (and implements what was 
missing for JSON-P 2.1 along the way).
   
   Right now only pluggability and SigTest TCK tests are failing, but those are 
related to the TCK not being set up properly as far as I can tell:
   ```
   [ERROR] Failures: 
   [ERROR]   ClientTests.jsonProviderTest1:103 jsonProviderTest1 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest11:343 jsonProviderTest11 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest12:365 jsonProviderTest12 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest13:388 jsonProviderTest13 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest14:410 jsonProviderTest14 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest15:433 jsonProviderTest15 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest16:455 jsonProviderTest16 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest17:477 jsonProviderTest17 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest18:500 jsonProviderTest18 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest2:132 jsonProviderTest2 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest3:162 jsonProviderTest3 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest4:181 jsonProviderTest4 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest5:204 jsonProviderTest5 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest6:227 jsonProviderTest5 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest7:250 jsonProviderTest7 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest8:273 jsonProviderTest8 Failed ==> 
expected: <true> but was: <false>
   [ERROR]   ClientTests.jsonProviderTest9:296 jsonProviderTest9 Failed ==> 
expected: <true> but was: <false>
   [ERROR] Errors: 
   [ERROR]   JSONPSigTest.signatureTest:281 Fault JSONPSigTest.signatureTest() 
failed!, diffs found
   [INFO] 
   [ERROR] Tests run: 197, Failures: 17, Errors: 1, Skipped: 0
   ```
   
   Draft PR for now because of two backwards-compatibility questions I'd like 
to discuss before merging:
   - keep `JohnzonJsonParser#current()`? It kind of is in the specs as 
`JsonParser#currentEvent()` now
   - continue to support the `johnzon.rejectDuplicateKeys` and 
`org.glassfish.json.rejectDuplicateKeys` properties for the duplicate keys 
mode? I'd at least like to drop the glassfish one as I can't find it anymore 
anywhere in jsonp 2.1 specs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@johnzon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to